-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable modeling of floating MHK turbines #1477
Conversation
…ons for fixed MHK turbines
…ons for floating MHK turbines
…and stiffness for floating MHK
I know you have done extensive testing with on this feature, particularly with flipping the tower in ED. Could you include a couple of plots of the testing here for future reference? |
There was a conflict after merging #1543. I resolved this with two commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this pull request, it tracks the change of tower heights and water level throughout the modules.
I have few random comments that are mostly personnal preferences and open to discussion, so they might be safe to discard :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not in favor of binary files added to the repo..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added to the AeroDyn documentation here (https://openfast.readthedocs.io/en/main/source/user/aerodyn/index.html), along with several other reference documents. I did not add it originally but noticed that it was not the most recent version, so just replaced it with the current version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't disagree, but until all of these Word documents get ported over to readthedocs, I'd prefer the Word docs get shared. Having Word documentation is better than no documentation!
…MHK turbine support structures and include equation for blade and tower buoyancy volume
To check the accuracy of changes made to OpenFAST to allow floating MHK turbines to be modeled with the tower and RNA below the platform, simulations were run with land-based wind turbine example cases. Comparisons were made between the original definitions of these turbines and definitions in which all components were below ground (i.e., assigned negative Z coordinates). To ensure both definitions were equivalent, a steady and uniform inflow was used, shaft tilt was set to zero, tower shadow effects were neglected, and gravity was negative for the "upside down" case. Several outputs for the |
@andrew-platt I have addressed all comments, and it should be good to go. I am not sure why one of the FF tests is now failing. |
This pull request is ready to be merged.
Development is complete, documentation has been updated, and all regression tests pass. A new floating MHK regression test has been added. A corresponding r-test branch is on the OpenFAST/r-test repository.
Feature or improvement description
This pull request allows floating MHK turbines to be modeled by allowing the tower, hub, nacelle, and rotor to be defined below the platform and below the MSL. For fixed and floating MHK turbines, the coordinate systems remain unchanged from those used for wind turbines. However, the geometry for fixed MHK turbines is defined relative to the seabed and for floating MHK turbines is defined relative to the MSL. InflowWind values are defined relative to the seabed for both fixed and floating MHK turbines.
Impacted areas of the software
Test results
All regression tests have been updated and pass. A new floating MHK regression test has been added.
Check list